Skip to content
Snippets Groups Projects
  1. Nov 02, 2016
    • Jo-Philipp Wich's avatar
      include: properly update .install stamp files · 317b3556
      Jo-Philipp Wich authored
      
      Right now the $(PKG_INSTALL_STAMP) files are only written if a package is
      selected as <*> but never deleted or emptied if the corresponding package
      is getting deselected.
      
      For ordinary packages this usually is no problem as the package/install
      recipe performs its own check for enabled packages when assembling the
      list of install stamp files to consider, but this logic might fail under
      certain circumstances for packages providing multiple build variants.
      
      In case of a multi-variant package, the buildroot first checks if any
      of the variants is enabled, then resolves all variants of the common
      source package and finally processes the corresponding .install stamp
      files of all variants, relying on the assumption that only the selected
      .install stamp file exists.
      
      When an initially selected variant is getting deselected or changed from
      <*> to <m> and another variant is marked as <*> instead, the .install
      stamp file of the deselected variant remains unchanged and a second
      .install stamp file for the newly selected variant is getting created,
      causing the package/install recipe to pick up two .install stamps with
      conflicting variants, leading to opkg file clashes.
      
      This issue happens for example if package "ip" is set to <m> and package
      "ip-full" to <*> -  the install command will eventually fail with:
      
           * check_conflicts_for: The following packages conflict with ip:
           * check_conflicts_for: 	ip-full *
           * opkg_install_cmd: Cannot install package ip.
      
      In order to fix the problem, always process the removal requests or the
      .install stamp files, even for deselected packages but only write the
      package base name into the stamp file if the corresponding package is
      marked as builtin.
      
      Signed-off-by: default avatarJo-Philipp Wich <jo@mein.io>
      317b3556
    • Jo-Philipp Wich's avatar
      scripts/package-metadata.pl: fix handling of virtual (PROVIDES) depends · f64360c7
      Jo-Philipp Wich authored
      
      Currently the code emitting dependencies for provide candidates is overwriting
      the specification calculated by the previous conditional dependency handling
      code, rendering dependencies on virtual PROVIDES packages in conjunction with
      conditional dependencies unusable.
      
      Instead of overwriting, append the PROVIDES dependency spec in order to fix
      using DEPENDS on virtual provider packages in conjunction with conditions.
      
      Signed-off-by: default avatarJo-Philipp Wich <jo@mein.io>
      f64360c7
  2. Nov 01, 2016
  3. Oct 31, 2016
  4. Oct 28, 2016
  5. Oct 27, 2016
Loading