Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • v17.01.1
  • v17.01.0
  • v17.01.0-rc2
  • v17.01.0-rc1
  • reboot
6 results
Search by author
  • Any Author
  • Johannes Rudolph Johannes Rudolph PowerPan
1 author
  1. May 05, 2015
  3. May 04, 2015
  5. May 02, 2015
  7. Apr 30, 2015
  9. Apr 29, 2015
  11. Apr 28, 2015
  13. Apr 23, 2015
  15. Apr 22, 2015
  17. Apr 21, 2015
  19. Apr 20, 2015
  21. Apr 19, 2015
  23. Apr 18, 2015
    • Felix Fietkau's avatar
      netifd: update to the latest version, fixes more device config handling issues · 6293aae9
      Felix Fietkau authored 
      
Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>

SVN-Revision: 45497
      6293aae9
    • Felix Fietkau's avatar
      iptables: remove obsolete files · 563c26a3
      Felix Fietkau authored 
      
Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>

SVN-Revision: 45494
      563c26a3
    • Steven Barth's avatar
      dropbear: update to 2015.67 · af4d04ed
      Steven Barth authored 
      
fixes dbclient login into OpenSSH 6.8p1
error: "Bad hostkey signature"

reported on irc, replicated with Arch Linux

Signed-off-by: default avatarDirk Neukirchen <dirkneukirchen@web.de>

SVN-Revision: 45493
      af4d04ed
    • John Crispin's avatar
      hostapd: Fix wps button hotplug script to handle multiple radios · 125b2ced
      John Crispin authored 
      Hostapd's control file location was changed in 2013, and that has apparently
broken the wps button hotplug script in cases where there are multiple radios
and wps is possibly configured also for the second radio. The current wps
button hotplug script always handles only the first radio.

https://dev.openwrt.org/browser/trunk/package/network/services/hostapd/files/wps-hotplug.sh

The reason is that the button hotplug script seeks directories like
/var/run/hostapd*, as the hostapd-phy0.conf files were earlier in
per-interface subdirectories.

Currently the *.conf files are directly in /var/run and the control sockets
are in /var/run/hostapd, but there is no subdirectory for each radio.

root@OpenWrt:/# ls /var/run/hostapd*
/var/run/hostapd-phy0.conf  /var/run/hostapd-phy1.conf

/var/run/hostapd:
wlan0  wlan1

The hotplug script was attempted to be fixed after the hostapd change by
r38986 in Dec2013, but that change only unbroke the script for the first
radio, but left it broken for multiple radios.
https://dev.openwrt.org/changeset/38986/



The script fails to find subdirectories with [ -d "$dir" ], and passes just
the only found directory /var/run/hostapd, leading into activating only the
first radio, as hostapd_cli defaults to first socket found inthe passed
directory:
root@OpenWrt:/# hostapd_cli -?
...
usage: hostapd_cli [-p<path>] [-i<ifname>] [-hvB] [-a<path>] \
                    [-G<ping interval>] [command..]
...
    -p<path>     path to find control sockets (default: /var/run/hostapd)
...
    -i<ifname>   Interface to listen on (default: first interface found in the
                 socket path)

Below is a run with the default script and with my proposed solution.

Default script (with logging added):
==================================
root@OpenWrt:/# cat /etc/rc.button/wps
#!/bin/sh

if [ "$ACTION" = "pressed" -a "$BUTTON" = "wps" ]; then
         for dir in /var/run/hostapd*; do
                 [ -d "$dir" ] || continue
                 logger "WPS activated for: $dir"
                 hostapd_cli -p "$dir" wps_pbc
         done
fi

 >>>> WPS BUTTON PRESSED <<<<<

root@OpenWrt:/# hostapd_cli -p /var/run/hostapd -i wlan0 wps_get_status
PBC Status: Active
Last WPS result: None
root@OpenWrt:/# hostapd_cli -p /var/run/hostapd -i wlan1 wps_get_status
PBC Status: Timed-out
Last WPS result: None
root@OpenWrt:/# logread | grep WPS
Tue Apr 14 18:38:50 2015 user.notice root: WPS activated for: /var/run/hostapd

wlan0 got WPS activated, while wlan1 remained inactive.

I have modified the script to search for sockets instead of directories and
to use the "-i" option with hostapd_cli, and now the script properly
activates wps for both radios. As "-i" needs the interface name instead of
the full path, the script first changes dir to /var/run/hostapd to get simply
the interface names.

Modified script (with logging):
===============================
root@OpenWrt:/# cat /etc/rc.button/wps
#!/bin/sh

if [ "$ACTION" = "pressed" -a "$BUTTON" = "wps" ]; then
         cd /var/run/hostapd
         for dir in *; do
                 [ -S "$socket" ] || continue
                 logger "WPS activated for: $socket"
                 hostapd_cli -i "$socket" wps_pbc
         done
fi

 >>>> WPS BUTTON PRESSED <<<<<

root@OpenWrt:/# hostapd_cli -p /var/run/hostapd -i wlan0 wps_get_status
PBC Status: Active
Last WPS result: None
root@OpenWrt:/# hostapd_cli -p /var/run/hostapd -i wlan1 wps_get_status
PBC Status: Active
Last WPS result: None
root@OpenWrt:/# logread | grep WPS
Tue Apr 14 18:53:06 2015 user.notice root: WPS activated for: wlan0
Tue Apr 14 18:53:06 2015 user.notice root: WPS activated for: wlan1

Both radios got their WPS activated properly.

I am not sure if my solution is optimal, but it seems to work. WPS button is
maybe not that often used functionality, but it might be fixed in any case.
Routers with multiple radios are common now, so the bug is maybe more
prominent than earlier.

The modified script has been in a slightly different format in my community
build since r42420 in September 2014.

Signed-off-by: default avatarHannu Nyman <hannu.nyman@iki.fi>

SVN-Revision: 45492
      125b2ced
  25. Apr 17, 2015
  27. Apr 15, 2015
  29. Apr 14, 2015
  31. Apr 13, 2015
  33. Apr 11, 2015
    • Felix Fietkau's avatar
      netifd: fix ieee80211r 'sh: bad number' in mac80211 setup (bug #19345) · e8a45bfc
      Felix Fietkau authored 
      Two errors "netifd: radio0: sh: bad number" have recently surfaced in system
log in trunk when wifi interfaces come up. I tracked the errors to checking
numerical values of some config options without ensuring that the option has
any value.

The errors I see have apparently been introduced by r45051 (ieee80211r in
hostapd) and r45326 (start_disabled in mac80211). My patches fix two
instances of "bad number", but there may be a third one, as the original
report in bug 19345 pre-dates r45326 and already has two "bad number" errors
for radio0.

https://dev.openwrt.org/ticket/19345



Signed-off-by: default avatarHannu Nyman <hannu.nyman@iki.fi>

SVN-Revision: 45380
      e8a45bfc
  35. Apr 10, 2015