Skip to content
Snippets Groups Projects
  1. Nov 27, 2016
  2. Oct 15, 2016
  3. Jun 07, 2016
  4. Mar 03, 2016
    • John Crispin's avatar
      kernel: gpio-button-hotplug: Add missing ONESHOT flag to threaded IRQ request · 4ac3411f
      John Crispin authored
      
      Without the IRQF_ONESHOT flag in devm_request_threaded_irq() call I get
      following error:
      
        genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 56
        gpio-keys gpio-keys: failed to request irq:56 for gpio:20
      
      >From kernel/irq/manage.c:
      
       The interrupt was requested with handler = NULL, so we use the default
       primary handler for it. But it does not have the oneshot flag set. In
       combination with level interrupts this is deadly, because the default
       primary handler just wakes the thread, then the irq lines is reenabled,
       but the device still has the level irq asserted. Rinse and repeat....
      
       While this works for edge type interrupts, we play it safe and reject
       unconditionally because we can't say for sure which type this interrupt
       really has. The type flags are unreliable as the underlying chip
       implementation can override them.
      
      Signed-off-by: default avatarPetr Štetiar <ynezz@true.cz>
      
      SVN-Revision: 48894
      4ac3411f
  5. Feb 12, 2016
  6. Jul 26, 2015
  7. Jan 24, 2015
  8. May 23, 2014
  9. May 14, 2014
  10. Mar 12, 2014
  11. Jan 14, 2014
  12. Dec 17, 2013
  13. Dec 09, 2013
  14. Nov 11, 2013
  15. Oct 28, 2013
  16. Aug 05, 2013
  17. Aug 03, 2013
  18. Aug 01, 2013
  19. Jul 02, 2013
  20. Jun 29, 2013
  21. Jun 21, 2013
Loading