Skip to content
Snippets Groups Projects
  • Mirko Vogt's avatar
    43365ca6
    Do not use $(V) - force AM_V=1 · 43365ca6
    Mirko Vogt authored
    Projects using silent-rules might otherwise fail to compile.
    
    This is due to the following resulting Makefile code:
    
    AM_V_P = $(am__v_P_$(V))
    am__v_P_ = $(am__v_P_$(AM_DEFAULT_VERBOSITY))
    am__v_P_0 = false
    am__v_P_1 = :
    
    Automake directly uses $(V) for variable name expansion
    which fails if $(V) is set to sth. else other than '0' or '1'.
    
    This patch forces automake to not take $(V) into account
    but to always use the default config for verbosity.
    
    A better approach would be to actually take $(V) into account,
    however not just pass it through (AM_V='$(V)') but
    set AM_V to 0 if $V=0 / unset and to 1 otherwise.
    
    This plan however is foiled due to my frustration about
    automake as well as my lack of m4 skills.
    
    automake bug report: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20077
    
    
    
    Signed-off-by: default avatarMirko Vogt <mirko@openwrt.org>
    
    SVN-Revision: 44684
    43365ca6
    History
    Do not use $(V) - force AM_V=1
    Mirko Vogt authored
    Projects using silent-rules might otherwise fail to compile.
    
    This is due to the following resulting Makefile code:
    
    AM_V_P = $(am__v_P_$(V))
    am__v_P_ = $(am__v_P_$(AM_DEFAULT_VERBOSITY))
    am__v_P_0 = false
    am__v_P_1 = :
    
    Automake directly uses $(V) for variable name expansion
    which fails if $(V) is set to sth. else other than '0' or '1'.
    
    This patch forces automake to not take $(V) into account
    but to always use the default config for verbosity.
    
    A better approach would be to actually take $(V) into account,
    however not just pass it through (AM_V='$(V)') but
    set AM_V to 0 if $V=0 / unset and to 1 otherwise.
    
    This plan however is foiled due to my frustration about
    automake as well as my lack of m4 skills.
    
    automake bug report: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20077
    
    
    
    Signed-off-by: default avatarMirko Vogt <mirko@openwrt.org>
    
    SVN-Revision: 44684