Skip to content
Snippets Groups Projects
  • Jing Qiu's avatar
    4475da96
    kernel: Fix the incorrect i_nlink count after jffs2's RENAME_EXCHANGE operations. · 4475da96
    Jing Qiu authored
    
    The problem is caused by the incorrect handling of the parent inode's
    i_nlink count for the dentry to be RENAME_EXCHANGED. There are 3 cases
    to consider. Assume we want to RENAME_EXCHANGE struct dentry *a and
    struct dentry *b, and inode_a is pointed to by dentry_a, inode_b is
    pointed to by dentry_b:
    
    1. If inode_a is a directory, but inode_b isn't, then we must decrease
       the i_nlink count of old_dir_i, and increase the i_nlink of new_dir_i.
    2. If inode_a isn't a directory, but inode_b is a directory, then we
       must increase the i_nlink of old_dir_i, and decrease the i_nlink count
       of new_dir_i.
    3. If the types of inode_a and inode_b are the same, we don't change the
       i_nlink for either old_dir_i or new_dir_i.
    
    Signed-off-by: default avatarJing Qiu <aqiu0720@gmail.com>
    Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
    4475da96
    History
    kernel: Fix the incorrect i_nlink count after jffs2's RENAME_EXCHANGE operations.
    Jing Qiu authored
    
    The problem is caused by the incorrect handling of the parent inode's
    i_nlink count for the dentry to be RENAME_EXCHANGED. There are 3 cases
    to consider. Assume we want to RENAME_EXCHANGE struct dentry *a and
    struct dentry *b, and inode_a is pointed to by dentry_a, inode_b is
    pointed to by dentry_b:
    
    1. If inode_a is a directory, but inode_b isn't, then we must decrease
       the i_nlink count of old_dir_i, and increase the i_nlink of new_dir_i.
    2. If inode_a isn't a directory, but inode_b is a directory, then we
       must increase the i_nlink of old_dir_i, and decrease the i_nlink count
       of new_dir_i.
    3. If the types of inode_a and inode_b are the same, we don't change the
       i_nlink for either old_dir_i or new_dir_i.
    
    Signed-off-by: default avatarJing Qiu <aqiu0720@gmail.com>
    Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>