From 3b4152bfda495105fac86c36bc791ccdb91ea142 Mon Sep 17 00:00:00 2001
From: John Crispin <john@openwrt.org>
Date: Fri, 27 Dec 2013 21:15:31 +0000
Subject: [PATCH] firmware-utils: check_magic() in buffalo-lib.c always return
0
spotted with cppcheck
Signed-off-by: Etienne CHAMPETIER <etienne.champetier@free.fr>
SVN-Revision: 39171
---
tools/firmware-utils/src/buffalo-lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/firmware-utils/src/buffalo-lib.c b/tools/firmware-utils/src/buffalo-lib.c
index 29aee9f88d..add3a7e023 100644
--- a/tools/firmware-utils/src/buffalo-lib.c
+++ b/tools/firmware-utils/src/buffalo-lib.c
@@ -249,10 +249,10 @@ static uint32_t get_be32(void *data)
static int check_magic(void *magic)
{
- if (!memcmp("start", magic, ENC_MAGIC_LEN));
+ if (!memcmp("start", magic, ENC_MAGIC_LEN))
return 0;
- if (!memcmp("asar1", magic, ENC_MAGIC_LEN));
+ if (!memcmp("asar1", magic, ENC_MAGIC_LEN))
return 0;
return -1;
--
GitLab